[PATCH] Using __isascii (POSIX) instead of isascii (deprecated).

Marek Kurdej curdeius at gmail.com
Wed Sep 17 06:35:06 PDT 2014


>>! In D5185#7, @thakis wrote:
> This directory contains https://code.google.com/p/googletest/ . I think the way to go about changing it is to get the change merged upstream, and then update this directory to what's in the upstream repo (?)

I checked the googletest page. The current version does not have this problem, because isascii is not used in 1.7.0.
LLVM uses a slightly modified version 1.6.0, so I see two possibilities:

  # Update googletest in LLVM to 1.7.0 (However, I do not know the general policy for handling external dependencies in LLVM)
  # Patch current version (That is what I propose, a short-term solution)

http://reviews.llvm.org/D5185






More information about the cfe-commits mailing list