[PATCH] Using __isascii (POSIX) instead of isascii (deprecated).

[Nico Weber]

On Wed, Sep 17, 2014 at 6:35 AM, Marek Kurdej <curdeius at gmail.com> wrote:

> >>! In D5185#7, @thakis wrote:
> > This directory contains https://code.google.com/p/googletest/ . I think
> the way to go about changing it is to get the change merged upstream, and
> then update this directory to what's in the upstream repo (?)
>
> I checked the googletest page. The current version does not have this
> problem, because isascii is not used in 1.7.0.
> LLVM uses a slightly modified version 1.6.0, so I see two possibilities:
>
>   # Update googletest in LLVM to 1.7.0 (However, I do not know the general
> policy for handling external dependencies in LLVM)
>   # Patch current version (That is what I propose, a short-term solution)
>

Upgrading to 1.7 sounds like it leads to a better place long-term than
staying on 1.6 and patching it up. Do others on this list have any opinion
on this? Does LLVM have existing policies for how to handle third-party
dependencies?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140917/cc4b8ae2/attachment.html>