[PATCH] ASTMatcher for Attr

Manuel Klimek klimek at google.com
Thu Aug 21 15:45:54 PDT 2014


On Thu Aug 21 2014 at 3:37:22 PM Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Thu, Aug 21, 2014 at 5:56 PM, Manuel Klimek <klimek at google.com> wrote:
> > +richard, since this is now touching lib/Basic...
> >
> > Looks good to me, but I want Richard to take a look whether this makes
> sense or should be solved differently.
>
> I am confused as to why the solution switched away from using the
> AttrKind enum value and is now using a string.
>

Note that the string is only for the dynamic matchers - the normal C++
matchers still use the enum.


>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140821/f2f42f8e/attachment.html>


More information about the cfe-commits mailing list