[PATCH] Downgrade the error about nested name specifiers when building with Microsoft extensions

[Ehsan Akhgari]

On Mon, Jun 30, 2014 at 1:11 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 28/06/2014 22:17, David Majnemer wrote:
>
>> Usually we only downgrade this kind of error if it was blocking a system
>> header, code that was automatically generated by some sort of IDL, or if it
>> is impractical to change the code in some other way.  Is that the case here?
>>
>> It's preferable, in my eyes, to keep it an error so that programmers make
>> their code conforming instead of just ignoring another warning fly by on
>> their terminal.
>>
>> I don't think clang-cl should mirror every bug in cl, just the important
>> ones.
>>
>
> The counterargument is that accepting MSVC quirks makes it easier to
> produce valid intermediate ASTs so that consumers can fix their source code
> automatically with refactoring instead of manually.
>
> That said, if the extension syntax doesn't appear much in the wild then
> fixing by hand is low-effort so it doesn't matter a great deal either way.


FWIW this is the Mozilla fix that I made:
https://hg.mozilla.org/mozilla-central/rev/db977537acef  It was pretty
simple.  :-)

--
Ehsan
<http://ehsanakhgari.org/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140630/1a905758/attachment.html>