patch: Fix RecursiveASTVisitor to visit types in ObjCPropertyDecl
alp at nuanti.com
Fri Jun 6 08:14:05 PDT 2014
On 02/06/2014 03:46, Mathieu Baudet wrote:
> Is there anything else I can do to help land this fix?
It looks good. I've gone ahead and landed this in r210339..
In the commit I've additionally applied the change into
DataRecursiveASTVisitor because we're converging the two copies --
AFAICT it'll be overridden in the latter case by handlers that know more
about Objective-C declarations so should be a no-op for libclang (which
is what we want).
Thanks for holding!
> -- Mathieu
> 2014-05-22 10:15 GMT-07:00 Mathieu Baudet <mathieu.baudet at gmail.com>:
>> Thanks for your feedback. Here is an updated patch.
>> -- Mathieu
>> 2014-05-21 20:37 GMT-07:00 Jordan Rose <jordan_rose at apple.com>:
>>> This seems reasonable to me, but I'd appreciate it if someone more familiar with RAV took a look. Also, this should probably be applied to the DataRecursiveASTVisitor too, at least until the merge is complete.
>>> On May 20, 2014, at 18:59 , Mathieu Baudet <mathieu.baudet at gmail.com> wrote:
>>>> I made the patch in attachment.
>>>> Hoping it is useful,
>>>> -- Mathieu
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
the browser experts
More information about the cfe-commits