r208176 - clang-format: Be slightly more aggressive on single-line functions.

Daniel Jasper djasper at google.com
Wed May 7 05:06:39 PDT 2014


I think it is, it makes the behavior consistent independent of the
superfluous semicolon at the end. I can add a test case in one of my next
commits.


On Wed, May 7, 2014 at 1:50 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 07/05/2014 13:20, Daniel Jasper wrote:
>
>> Why is this using an elaborated return type? Can you just remove the
>> "struct"?
>>
>
> I just rebuilt clang-format and I found another formatting change:
>
> -  ReportFuncCall(Instruction *Inst) : Inst(Inst) {
> -    ++BadFuncCallForScop;
> -  };
> +  ReportFuncCall(Instruction *Inst) : Inst(Inst) { ++BadFuncCallForScop;
> }; <- This is just one line
>
> Was this intentional as well? In case it was, maybe it is worth adding
> some non-js tests here.
>
> Tobias
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140507/62f21b8d/attachment.html>


More information about the cfe-commits mailing list