r204493 - Make clang/test/lit.cfg pre-scan the RUN line looking for tool names,

Robinson, Paul Paul_Robinson at playstation.sony.com
Mon Mar 24 11:26:41 PDT 2014


> Paul, excuse me, I have reverted it in r204539.

Very sorry for breakage.

> Please note,
>   - llvm_tools_dir might not contain just-built clang executables,
> esp. in the case of "standalone clang".
>     You should seek also clang_tools_dir.

Okay.

>   - "FileCheck" "count" and "not" may or may not be in llvm_tools_dir,
> depend on
>     whether llvm_tools_dir points built tree or installed tree.

Are you sure? See code starting at line 96, which adds only
llvm_tools_dir and clang_tools_dir to PATH. These tools must be
on PATH (without my change) or tests will not work.  So I think 
they must be in either llvm_tools_dir or clang_tools_dir.

> 
> ...Takumi

Attached patch searches both llvm_tools_dir and clang_tools_dir,
but still checks for "FileCheck" "count" and "not".
Could you please verify for me? I am not sure how to set up a
standalone clang tree.

Thanks,
--paulr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-lit-cfg.diff
Type: application/octet-stream
Size: 2134 bytes
Desc: clang-lit-cfg.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140324/04ff8705/attachment.obj>


More information about the cfe-commits mailing list