[PATCH] Atomics: emit cmpxchg instructions with weaker failure-order

Tim Northover t.p.northover at gmail.com
Thu Mar 13 12:33:42 PDT 2014


  Thanks. I've committed the extension as r203837 and the pure refactoring in your most recent message as r203838.

  Tim.


================
Comment at: lib/CodeGen/CGAtomic.cpp:281
@@ +280,3 @@
+    SI->addCase(CGF.Builder.getInt32(1), AcquireBB);
+    SI->addCase(CGF.Builder.getInt32(2), AcquireBB);
+  }
----------------
JF Bastien wrote:
> Wouldn't it be better to use AtomicOrderingKind here instead of the values? Same a few lines below, and around ~700.
Ach, yes! I made a mental note to do that during the copy/paste but forgot to actually do it.


http://llvm-reviews.chandlerc.com/D3053



More information about the cfe-commits mailing list