[PATCH] Fix PR19104: Incorrect handling of non-virtual calls of virtual methods

Timur Iskhodzhanov timurrrr at google.com
Wed Mar 12 06:29:42 PDT 2014


Hi majnemer, rnk,

This also simplifies the handling of this argument adjustment when calling destructors.

David,
Reid is on vacation and the revision log says you're quite familiar with these files.
I'd like you to do a general review of the patch so I can commit sooner.

Reid,
I assume you'll do a thorough post-commit review when you're back.

http://llvm-reviews.chandlerc.com/D3054

Files:
  lib/CodeGen/CGCXXABI.h
  lib/CodeGen/CGExprCXX.cpp
  lib/CodeGen/ItaniumCXXABI.cpp
  lib/CodeGen/MicrosoftCXXABI.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3054.1.patch
Type: text/x-patch
Size: 13219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140312/9656275e/attachment.bin>


More information about the cfe-commits mailing list