[PATCH][REVIEW REQUEST] Fix for libclang completion of already declared template friends.

[David Majnemer]

I can't speak to the patch's correctness with regards to code completion,
however your patch is in violation of our coding standards.

The project uses two space indents and avoids braces after control
statements.


On Sun Mar 09 2014 at 11:06:26 AM, Francisco Lopes <
francisco.mailing.lists at oblita.com> wrote:

> Hi,
> attached is a new patch that fix the previously mentioned issue too.
> Please review.
>
>
> 2014-03-08 14:16 GMT-03:00 Francisco Lopes <francisco.mailing.lists@
> oblita.com>:
>
> s/template arguments/template parameters/
>>
>>
>> 2014-03-08 14:04 GMT-03:00 Francisco Lopes <francisco.mailing.lists@
>> oblita.com>:
>>
>> Hello, situation now at revision 203332 seems even worst, for example,
>>> it's not providing completion for boost::shared_ptr not even once, as was
>>> happening before.
>>>
>>> Also, this patch doesn't solve all the situation, I just realized the
>>> single
>>> side effect I've found in this is that, the first completion shows
>>> template
>>> arguments of the template declaration, which is right, but at the second
>>> completion it starts to show template parameter names as set in the
>>> template friend, not at the original declaration.
>>>
>>> I'm not sure what's the way out of this, any suggestion is appreciated.
>>>
>>> Regards,
>>> Francisco Lopes.
>>>
>>>
>>>
>>> 2014-03-07 14:47 GMT-03:00 Francisco Lopes <francisco.mailing.lists@
>>> oblita.com>:
>>>
>>> Hi,
>>>> attached is a patch that tries to fix libclang bug 13699<http://llvm.org/bugs/show_bug.cgi?id=13699>
>>>> .
>>>> Please review.
>>>>
>>>> --
>>>> Francisco Lopes
>>>>
>>>> PS:
>>>> I have requested commit access in late 2012 but never made a test
>>>> commit or anything.
>>>>
>>>> At the time I have received from Chris Lattner:
>>>> "I'm sorry for the delay, I've been fighting mailing list issues.
>>>> Commit after approval access is granted.  Please try a test commit!"
>>>>
>>>> I'm not sure whether it's still valid.
>>>>
>>>
>>>
>>  _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140309/25e54aae/attachment.html>