<div dir="ltr">I can't speak to the patch's correctness with regards to code completion, however your patch is in violation of our coding standards.<br><div><br></div><div><div style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;line-height:16px">
The project uses two space indents and avoids braces after control statements.</div></div><div style="color:rgb(51,51,51);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;line-height:16px"><br>
</div><br><div>On Sun Mar 09 2014 at 11:06:26 AM, Francisco Lopes <<a href="mailto:francisco.mailing.lists@oblita.com" target="_blank">francisco.mailing.lists@oblita.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Hi,<br>attached is a new patch that fix the previously mentioned issue too.<br>Please review.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-08 14:16 GMT-03:00 Francisco Lopes <span dir="ltr"><<a href="mailto:francisco.mailing.lists@oblita.com" target="_blank">francisco.mailing.lists@<u></u>oblita.com</a>></span>:</div>
</div><div class="gmail_extra"><div class="gmail_quote"><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">s/template arguments/template parameters/</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">
2014-03-08 14:04 GMT-03:00 Francisco Lopes <span dir="ltr"><<a href="mailto:francisco.mailing.lists@oblita.com" target="_blank">francisco.mailing.lists@<u></u>oblita.com</a>></span>:<div><div><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div>Hello, situation now at revision 203332 seems even worst, for example,<br>
it's not providing completion for boost::shared_ptr not even once, as was<br>happening before.<br>
<br></div>Also, this patch doesn't solve all the situation, I just realized the single<br></div><div>side effect I've found in this is that, the first completion shows template<br></div><div>arguments of the template declaration, which is right, but at the second<br>
</div><div>completion it starts to show template parameter names as set in the<br></div><div>template friend, not at the original declaration.<br><br></div><div>I'm not sure what's the way out of this, any suggestion is appreciated.<br>
<br></div><div>Regards,<br></div><div>Francisco Lopes.<br></div></div></div></div></div></div><div><div><div><div><div><div><br></div></div></div></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
2014-03-07 14:47 GMT-03:00 Francisco Lopes <span dir="ltr"><<a href="mailto:francisco.mailing.lists@oblita.com" target="_blank">francisco.mailing.lists@<u></u>oblita.com</a>></span>:<div><div><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div><div><div><div><div>Hi,<br>attached is a patch that tries to fix <a href="http://llvm.org/bugs/show_bug.cgi?id=13699" target="_blank">libclang bug 13699</a>.<br></div>Please review.<br><br></div>
--<br>
</div>Francisco Lopes<br>
<br></div>PS:<br>I have requested commit access in late 2012 but never made a test commit or anything.<br><br></div>At the time I have received from Chris Lattner:<br>"I'm sorry for the delay, I've been fighting mailing list issues.<br>
Commit
after approval access is granted. Please try a test commit!"<br><br></div>I'm not sure whether it's still valid.<br></div>
</blockquote></div></div></div><br></div>
</blockquote></div></div></div><br></div>
</blockquote></div></div>
______________________________<u></u><u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailm<u></u>an/listinfo/cfe-commits</a><br>
</blockquote></div>