r203014 - Updating this test case to appease build bots which support ANSI escape sequences (unlike my dev box).

[Pete Cooper]

Hi Aaron

This is breaking the buildbots.  Any chance you can look in to this, or revert it until we can work out the breakage?

Thanks,
Pete

clang/src/tools/clang/test/Misc/ast-dump-color.cpp:62:10: error: expected string not found in input
//CHECK: {{^}}[[Blue]]| |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]] 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability ""{{$}}
         ^
<stdin>:35:1: note: scanning from here
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Blue" equal to "\033[0;34m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "BLUE" equal to "\033[0;1;34m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Yellow" equal to "\033[0;33m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Yellow" equal to "\033[0;33m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:37: note: possible intended match here
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
                                    ^

--

********************

On Mar 5, 2014, at 2:15 PM, Aaron Ballman <aaron at aaronballman.com> wrote:

> On Wed, Mar 5, 2014 at 5:14 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>> On 5 Mar 2014 14:11, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>>> 
>>> On Wed, Mar 5, 2014 at 5:09 PM, Richard Smith <richard at metafoo.co.uk>
>>> wrote:
>>>> On 5 Mar 2014 14:06, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>>>>> 
>>>>> Author: aaronballman
>>>>> Date: Wed Mar  5 15:59:02 2014
>>>>> New Revision: 203014
>>>>> 
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=203014&view=rev
>>>>> Log:
>>>>> Updating this test case to appease build bots which support ANSI escape
>>>>> sequences (unlike my dev box).
>>>>> 
>>>>> Modified:
>>>>>    cfe/trunk/test/Misc/ast-dump-color.cpp
>>>>> 
>>>>> Modified: cfe/trunk/test/Misc/ast-dump-color.cpp
>>>>> URL:
>>>>> 
>>>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-color.cpp?rev=203014&r1=203013&r2=203014&view=diff
>>>>> 
>>>>> 
>>>>> ==============================================================================
>>>>> --- cfe/trunk/test/Misc/ast-dump-color.cpp (original)
>>>>> +++ cfe/trunk/test/Misc/ast-dump-color.cpp Wed Mar  5 15:59:02 2014
>>>>> @@ -59,7 +59,7 @@ int TestExpr __attribute__((guarded_by(m
>>>>> //CHECK: {{^}}[[Blue]]|
>>>>> `-[[RESET]][[YELLOW]]ParagraphComment[[RESET]][[Yellow]]
>>>>> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]],
>>>>> [[Yellow]]col:11[[RESET]]>{{$}}
>>>>> //CHECK: {{^}}[[Blue]]|
>>>>> `-[[RESET]][[YELLOW]]TextComment[[RESET]][[Yellow]]
>>>>> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]],
>>>>> [[Yellow]]col:11[[RESET]]> Text=" Comment"{{$}}
>>>>> //CHECK:
>>>>> {{^}}[[Blue]]|-[[RESET]][[GREEN]]CXXRecordDecl[[RESET]][[Yellow]]
>>>>> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:1[[RESET]],
>>>>> [[Yellow]]line:25:1[[RESET]]> class[[CYAN]] Mutex[[RESET]]
>>>>> definition{{$}}
>>>>> -//CHECK: {{^}}[[Blue]]|
>>>>> |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]]
>>>>> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability
>>>>> ""{{$}}
>>>>> +//CHECK: {{^}}[[Blue]]|
>>>>> |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]]
>>>>> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability
>>>>> "mutex"{{$}}
>>>> 
>>>> Huh? How do ANSI color sequences affect whether this line ends "" or
>>>> "mutex"?
>>> 
>>> They don't -- I'm merely muttering that this test never runs for me on
>>> my Windows box, so I always seem to break it and only find out by
>>> annoying the build bots.
>> 
>> Ah, I see. Can we improve this test to also cope with the various [[things]]
>> expanding to empty strings, so we can enable it unconditionally?
> 
> Uncertain, but definitely worth me spending some time looking into.
> 
> ~Aaron
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140305/e51d733d/attachment.html>