<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Aaron<div><br></div><div>This is breaking the buildbots.  Any chance you can look in to this, or revert it until we can work out the breakage?</div><div><br></div><div>Thanks,</div><div>Pete</div><div><br></div><div><pre style="font-family: 'Courier New', courier, monotype, monospace; font-size: medium;"><span class="stdout">clang/src/tools/clang/test/Misc/ast-dump-color.cpp:62:10: error: expected string not found in input
//CHECK: {{^}}[[Blue]]| |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]] 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability ""{{$}}
         ^
<stdin>:35:1: note: scanning from here
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Blue" equal to "\033[0;34m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "BLUE" equal to "\033[0;1;34m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Yellow" equal to "\033[0;33m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "Yellow" equal to "\033[0;33m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:1: note: with variable "RESET" equal to "\033[0m"
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
^
<stdin>:35:37: note: possible intended match here
| |-CapabilityAttr 0x1028766f0 <line:18:22> capability "mutex"
                                    ^

--

********************</span></pre><div><br></div><div><div>On Mar 5, 2014, at 2:15 PM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Wed, Mar 5, 2014 at 5:14 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br><blockquote type="cite">On 5 Mar 2014 14:11, "Aaron Ballman" <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br><blockquote type="cite"><br>On Wed, Mar 5, 2014 at 5:09 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>><br>wrote:<br><blockquote type="cite">On 5 Mar 2014 14:06, "Aaron Ballman" <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br><blockquote type="cite"><br>Author: aaronballman<br>Date: Wed Mar  5 15:59:02 2014<br>New Revision: 203014<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=203014&view=rev">http://llvm.org/viewvc/llvm-project?rev=203014&view=rev</a><br>Log:<br>Updating this test case to appease build bots which support ANSI escape<br>sequences (unlike my dev box).<br><br>Modified:<br>   cfe/trunk/test/Misc/ast-dump-color.cpp<br><br>Modified: cfe/trunk/test/Misc/ast-dump-color.cpp<br>URL:<br><br><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-color.cpp?rev=203014&r1=203013&r2=203014&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-color.cpp?rev=203014&r1=203013&r2=203014&view=diff</a><br><br><br>==============================================================================<br>--- cfe/trunk/test/Misc/ast-dump-color.cpp (original)<br>+++ cfe/trunk/test/Misc/ast-dump-color.cpp Wed Mar  5 15:59:02 2014<br>@@ -59,7 +59,7 @@ int TestExpr __attribute__((guarded_by(m<br>//CHECK: {{^}}[[Blue]]|<br>`-[[RESET]][[YELLOW]]ParagraphComment[[RESET]][[Yellow]]<br>0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]],<br>[[Yellow]]col:11[[RESET]]>{{$}}<br>//CHECK: {{^}}[[Blue]]|<br>`-[[RESET]][[YELLOW]]TextComment[[RESET]][[Yellow]]<br>0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]],<br>[[Yellow]]col:11[[RESET]]> Text=" Comment"{{$}}<br>//CHECK:<br>{{^}}[[Blue]]|-[[RESET]][[GREEN]]CXXRecordDecl[[RESET]][[Yellow]]<br>0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:1[[RESET]],<br>[[Yellow]]line:25:1[[RESET]]> class[[CYAN]] Mutex[[RESET]]<br>definition{{$}}<br>-//CHECK: {{^}}[[Blue]]|<br>|-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]]<br>0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability<br>""{{$}}<br>+//CHECK: {{^}}[[Blue]]|<br>|-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]]<br>0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability<br>"mutex"{{$}}<br></blockquote><br>Huh? How do ANSI color sequences affect whether this line ends "" or<br>"mutex"?<br></blockquote><br>They don't -- I'm merely muttering that this test never runs for me on<br>my Windows box, so I always seem to break it and only find out by<br>annoying the build bots.<br></blockquote><br>Ah, I see. Can we improve this test to also cope with the various [[things]]<br>expanding to empty strings, so we can enable it unconditionally?<br></blockquote><br>Uncertain, but definitely worth me spending some time looking into.<br><br>~Aaron<br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></div></body></html>