[PATCH] Target-specific attributes
aaron at aaronballman.com
Thu Jan 9 15:04:28 PST 2014
Thanks! Committed in r198896.
On Thu, Jan 9, 2014 at 5:37 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> LGTM, thanks!
> + default:
> + // Type attributes are handled elsewhere; silently move on.
> + assert(Attr.isTypeAttr() && "Non-type attribute not handled");
> + break;
> Eventually it'd be nice to be able to TableGen a list of attributes we don't
> expect to see here, so we can automatically generate case labels for them,
> and get a compile-time error if something is missing from this switch
I agree, that's a good idea.
More information about the cfe-commits