[PATCH] Target-specific attributes
richard at metafoo.co.uk
Thu Jan 9 14:37:20 PST 2014
+ // Type attributes are handled elsewhere; silently move on.
+ assert(Attr.isTypeAttr() && "Non-type attribute not handled");
Eventually it'd be nice to be able to TableGen a list of attributes we
don't expect to see here, so we can automatically generate case labels for
them, and get a compile-time error if something is missing from this switch
On Thu, Jan 9, 2014 at 2:28 PM, Aaron Ballman <aaron at aaronballman.com>wrote:
> On Sat, Jan 4, 2014 at 11:33 AM, Aaron Ballman <aaron at aaronballman.com>
> > New Years ping, with another rebased patch. :-)
> > ~Aaron
> > On Fri, Dec 27, 2013 at 12:10 PM, Aaron Ballman <aaron at aaronballman.com>
> >> Holiday ping, with rebased patch.
> >> ~Aaron
> >> On Thu, Dec 19, 2013 at 10:11 AM, Aaron Ballman <aaron at aaronballman.com>
> >>> Ping
> >>> On Sun, Dec 15, 2013 at 8:49 AM, Aaron Ballman <aaron at aaronballman.com>
> >>>> This patch removes the TargetAttributesSema concept and replaces it
> >>>> with one where the parsed attributes are responsible for knowing their
> >>>> target-specific nature, instead of letting Sema figure it out. This is
> >>>> necessary so that __has_attribute can eventually determine whether a
> >>>> parsed attribute applies to the given target or not.
> >>>> All of the semantic handling which was previously in
> >>>> TargetAttributesSema.cpp has been moved to SemaDeclAttr.cpp, but still
> >>>> only applies to the specific target by asking the attribute whether it
> >>>> exists in the given target or not. The target-specific information is
> >>>> generated automatically via tablegen.
> >>>> ~Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits