r198805 - Attempting a fix the build bots should be happier with. Amends 198804.

Richard Smith metafoo at gmail.com
Wed Jan 8 18:37:23 PST 2014


This newer fix is preferable generally: avoiding the 'default' case causes
us to get a warning if an extra value is added to the DeclSpecContext enum
but isn't handled in this switch.

On Wed Jan 08 2014 at 3:33:25 PM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> Author: aaronballman
> Date: Wed Jan  8 17:26:53 2014
> New Revision: 198805
>
> URL: http://llvm.org/viewvc/llvm-project?rev=198805&view=rev
> Log:
> Attempting a fix the build bots should be happier with. Amends 198804.
>
> Modified:
>     cfe/trunk/include/clang/Parse/Parser.h
>
> Modified: cfe/trunk/include/clang/Parse/Parser.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/
> clang/Parse/Parser.h?rev=198805&r1=198804&r2=198805&view=diff
> ============================================================
> ==================
> --- cfe/trunk/include/clang/Parse/Parser.h (original)
> +++ cfe/trunk/include/clang/Parse/Parser.h Wed Jan  8 17:26:53 2014
> @@ -1654,8 +1654,6 @@ private:
>    /// trailing-type-specifier)?
>    static bool isTypeSpecifier(DeclSpecContext DSC) {
>      switch (DSC) {
> -    default:
> -      llvm_unreachable("Missing DeclSpecContext case");
>      case DSC_normal:
>      case DSC_class:
>      case DSC_top_level:
> @@ -1666,6 +1664,7 @@ private:
>      case DSC_alias_declaration:
>        return true;
>      }
> +    llvm_unreachable("Missing DeclSpecContext case");
>    }
>
>    /// Information on a C++0x for-range-initializer found while parsing a
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140109/bfd0dea3/attachment.html>


More information about the cfe-commits mailing list