This newer fix is preferable generally: avoiding the 'default' case causes us to get a warning if an extra value is added to the DeclSpecContext enum but isn't handled in this switch.<br><br><div>On Wed Jan 08 2014 at 3:33:25 PM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aaronballman<br>
Date: Wed Jan  8 17:26:53 2014<br>
New Revision: 198805<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198805&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=198805&view=rev</a><br>
Log:<br>
Attempting a fix the build bots should be happier with. Amends 198804.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Parse/<u></u>Parser.h<br>
<br>
Modified: cfe/trunk/include/clang/Parse/<u></u>Parser.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Parse/Parser.h?rev=198805&r1=198804&r2=198805&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/include/<u></u>clang/Parse/Parser.h?rev=<u></u>198805&r1=198804&r2=198805&<u></u>view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/include/clang/Parse/<u></u>Parser.h (original)<br>
+++ cfe/trunk/include/clang/Parse/<u></u>Parser.h Wed Jan  8 17:26:53 2014<br>
@@ -1654,8 +1654,6 @@ private:<br>
   /// trailing-type-specifier)?<br>
   static bool isTypeSpecifier(<u></u>DeclSpecContext DSC) {<br>
     switch (DSC) {<br>
-    default:<br>
-      llvm_unreachable("Missing DeclSpecContext case");<br>
     case DSC_normal:<br>
     case DSC_class:<br>
     case DSC_top_level:<br>
@@ -1666,6 +1664,7 @@ private:<br>
     case DSC_alias_declaration:<br>
       return true;<br>
     }<br>
+    llvm_unreachable("Missing DeclSpecContext case");<br>
   }<br>
<br>
   /// Information on a C++0x for-range-initializer found while parsing a<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote>