[PATCH] PR18327: -Wsystem-headers introduces build errors

[Richard Smith]

On Mon, Jan 6, 2014 at 1:11 PM, Alp Toker <alp at nuanti.com> wrote:

> Some further late-breaking thoughts below..
>
>
>
> On 06/01/2014 19:27, Richard Smith wrote:
>
>  So -Wsystem-headers would allow warnings (but not errors) to be produced
>> in system headers
>>
>
> ^ This mode doesn't sound useful or in line with user expectations: Anyone
> requesting to see warnings in system headers almost certainly also wants to
> see errors in headers, even if demoted to warnings, but certainly not to
> have them silently ignored without any diagnostic message.


Perhaps I didn't explain clearly what I meant. None of my suggestions
proposed changing the behavior of warning flags outside system headers.
-Wsystem-headers would only affect warnings that are enabled outside system
headers.


>  , and -Werror=system-headers would also allow errors to be produced in
>> system headers.
>>
>
> ^ If -Werror=system-headers were ever to be supported it should make all
> warnings in system headers turn into errors, not just enable errors that
> are usually invisible. I don't think either is a particularly useful mode
> as long as we have basic -Werror -Wsystem-headers working correctly (change
> proposed in my previous mail).
>
>
> Alp.
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140106/e491a710/attachment.html>