[PATCH] Added an option to avoid splitting certain kinds of comments into lines.
alp at nuanti.com
Thu Jan 2 02:37:46 PST 2014
On 02/01/2014 10:24, Manuel Klimek wrote:
> On Thu, Jan 2, 2014 at 11:21 AM, Alp Toker <alp at nuanti.com
> <mailto:alp at nuanti.com>> wrote:
> Just saw this after Manuel replied.
> Is it OK to reformat IWYU pragmas in other coding styles, say in
> the LLVM style?
> I think we mainly want to not have *all* pragmas in *all* coding
> styles. IWYU is just an example, and we can easily add it to other styles.
> If not, that's an indication this kind of setting should be
> separated from individual coding style descriptions as it appears
> equally applicable to WebKit, Chromium, LLVM and custom styles.
> Well, you can set it for all of those? What is your proposed solution?
A quick fix without major surgery on the proposed patch would be to have
the same default value, or empty default value, shared between all
built-in coding styles so that switching between them doesn't change
This makes sense because non-reformatted comment pragmas are
project-level / user-level settings not related to or really defined by
any coding style.
This'll be great for lit RUN lines too(!)
> It seems prudent not to add a public config setting with a
> commitment of stability until that's addressed or it'll be hard to
> fix after the fact.
> On 02/01/2014 09:58, Manuel Klimek wrote:
> Comment at: unittests/Format/FormatTest.cpp:1053
> @@ +1052,3 @@
> + "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb",
> + format("// IWYU pragma: aaaaaaaaaaaaaaaaaa
> bbbbbbbbbbbbbb", Pragmas));
> Please add a short test for block comments.
> ARCANIST PROJECT
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
> the browser experts
the browser experts
More information about the cfe-commits