[PATCH] Added an option to avoid splitting certain kinds of comments into lines.

[Manuel Klimek]

On Thu, Jan 2, 2014 at 11:21 AM, Alp Toker <alp at nuanti.com> wrote:

> Just saw this after Manuel replied.
>
> Is it OK to reformat IWYU pragmas in other coding styles, say in the LLVM
> style?
>

I think we mainly want to not have *all* pragmas in *all* coding styles.
IWYU is just an example, and we can easily add it to other styles.


> If not, that's an indication this kind of setting should be separated from
> individual coding style descriptions as it appears equally applicable to
> WebKit, Chromium, LLVM and custom styles.
>

Well, you can set it for all of those? What is your proposed solution?

Cheers,
/Manuel


>
> It seems prudent not to add a public config setting with a commitment of
> stability until that's addressed or it'll be hard to fix after the fact.
>
> Alp.
>
>
> On 02/01/2014 09:58, Manuel Klimek wrote:
>
>>    lg
>>
>>
>> ================
>> Comment at: unittests/Format/FormatTest.cpp:1053
>> @@ +1052,3 @@
>> +      "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb",
>> +      format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb",
>> Pragmas));
>> +}
>> ----------------
>> Please add a short test for block comments.
>>
>>
>> http://llvm-reviews.chandlerc.com/D2460
>>
>> BRANCH
>>    svn
>>
>> ARCANIST PROJECT
>>    clang
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140102/48760489/attachment.html>