r197252 - Tighten test regexes checking for __attribute__((thiscall)) on function types.

Hans Wennborg hans at chromium.org
Sun Dec 15 10:12:46 PST 2013

On Sun, Dec 15, 2013 at 3:40 AM, Alp Toker <alp at nuanti.com> wrote:
> Hans, do you think it'd make sense to make the MSVC syntax default in the
> diagnostic pretty printer?
> At least "__thiscall" syntax is easier on the eyes and easier to match with
> a regex.

I agree that matching "__thiscall" would be nicer, but that syntax
only works when -fms-extensions is enabled.

I think the better solution here is to figure out a way to suppress
printing the calling-convention when it's the default one for the ABI
and not explicitly specified by the user.

At least the tests are now precise enough that they won't silently
accept any new behaviour :)

 - Hans

More information about the cfe-commits mailing list