XCore target Type defines
rafael.espindola at gmail.com
Mon Nov 4 09:36:55 PST 2013
On 4 November 2013 08:55, Robert Lytton <robert at xmos.com> wrote:
> Hi Rafael,
> The changes are to bring clang inline with the current llvm-gcc port for XCore.
> Hence, WCharType is an unsigned 8bit and WIntType is a signed 32bit.
> I believe the test already in test/Preprocessor/stdint.c cover the other cases.
> This does lead to question why the change was needed.
> It just seemed a good idea to make them explicit.
> Could you advise what I should have done please.
Please double check that there are tests. If the patch is just making
it explicit, that is fine. If not, please add the missing tests. LGTM
More information about the cfe-commits