XCore target Type defines

Robert Lytton robert at xmos.com
Mon Nov 4 08:55:29 PST 2013

Hi Rafael,

The changes are to bring clang inline with the current llvm-gcc port for XCore.
Hence, WCharType is an unsigned 8bit and WIntType is a signed 32bit.

I believe the test already in test/Preprocessor/stdint.c cover the other cases.
This does lead to question why the change was needed.
It just seemed a good idea to make them explicit.
Could you advise what I should have done please.

Thank you


From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
Sent: 04 November 2013 15:35
To: Robert Lytton
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: XCore target Type defines

Is Xcode the only system with a 8 byte wchar? Is that valid according
to the standard?

You are changing 5 types (SizeType, PtrDiffType, IntPtrType,
WCharType, WIntType) but only updating tests for 2. Why?

On 21 October 2013 02:17, Robert Lytton <robert at xmos.com> wrote:
> Hi
> Is this good to go?
> Thank you.
> Robert
> ________________________________
> From: cfe-commits-bounces at cs.uiuc.edu [cfe-commits-bounces at cs.uiuc.edu] on
> behalf of Robert Lytton [robert at xmos.com]
> Sent: 16 October 2013 17:06
> To: cfe-commits at cs.uiuc.edu
> Subject: XCore target Type defines
> Hi,
> Here is a patch to change SizeType, PtrDiffType, IntPtrType, WCharType,
> WIntType
> for the xcore target so they are the same as the XMOS llvm-gcc front end's
> settings!
> Robert
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list