[PATCH] [extra] pptrace - preprocessor tracing and testing tool

John Thompson john.thompson.jtsoftware at gmail.com
Fri Oct 25 08:45:20 PDT 2013


  On second thought, aren't function members supposed start with a lower case?  Are the other functions wrong, or is there a convention for virtual/callback functions?


================
Comment at: pp-trace/PPCallbacksTracker.cpp:176
@@ +175,3 @@
+                                      const clang::Module *Imported) {
+  beginCallback("moduleImport");
+  appendArgument("ImportLoc", ImportLoc);
----------------
Sean Silva wrote:
> Any particular reason why the capitalization for this is different from the rest?
It's like this in the base class.  I'll fix it in a separate checkin.



http://llvm-reviews.chandlerc.com/D2020



More information about the cfe-commits mailing list