[PATCH] [extra] pptrace - preprocessor tracing and testing tool

[Sean Silva]

On Fri, Oct 25, 2013 at 11:45 AM, John Thompson <
john.thompson.jtsoftware at gmail.com> wrote:

>
>   On second thought, aren't function members supposed start with a lower
> case?  Are the other functions wrong, or is there a convention for
> virtual/callback functions?
>

The "old style" capitalized functions, and this is just a carry-over. I see
now that these names are just matching the virtual function names, in which
case I think that the way you have it is actually just fine.

-- Sean Silva


>
>
> ================
> Comment at: pp-trace/PPCallbacksTracker.cpp:176
> @@ +175,3 @@
> +                                      const clang::Module *Imported) {
> +  beginCallback("moduleImport");
> +  appendArgument("ImportLoc", ImportLoc);
> ----------------
> Sean Silva wrote:
> > Any particular reason why the capitalization for this is different from
> the rest?
> It's like this in the base class.  I'll fix it in a separate checkin.
>
>
>
> http://llvm-reviews.chandlerc.com/D2020
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131025/2b4e0252/attachment.html>