[patch] Refactor the Used flag logic (and a small bug fix)

Richard Smith richard at metafoo.co.uk
Thu Oct 24 18:25:59 PDT 2013


On Wed, Oct 23, 2013 at 10:28 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 23 October 2013 12:48, Rafael EspĂ­ndola <rafael.espindola at gmail.com>
> wrote:
> > I am having second thoughts about this patch. IsUsed is a common
> > operation. We probably don't want to loop in it. We could loop in
> > setUsed to set every decl used, but we still have the problem of what
> > to do about UsedAttr.
> >
> > In the end having the callers be careful might be the best, but
> > brittle, solution. I will see if I can fix the small bug without
> > introducing a loop in isUsed.
>
> OK. Attached is a patch that fixes the bug and nothing else. That way
> we should be able to discuss the refactoring in isolation.


Sounds good, go ahead.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131024/b4485717/attachment.html>


More information about the cfe-commits mailing list