[patch] Refactor the Used flag logic (and a small bug fix)

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Oct 23 10:28:31 PDT 2013

On 23 October 2013 12:48, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> I am having second thoughts about this patch. IsUsed is a common
> operation. We probably don't want to loop in it. We could loop in
> setUsed to set every decl used, but we still have the problem of what
> to do about UsedAttr.
> In the end having the callers be careful might be the best, but
> brittle, solution. I will see if I can fix the small bug without
> introducing a loop in isUsed.

OK. Attached is a patch that fixes the bug and nothing else. That way
we should be able to discuss the refactoring in isolation.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 1370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131023/2d7cc379/attachment.bin>

More information about the cfe-commits mailing list