patch: sanitizer summaries are redundant, don't emit them

Nick Lewycky nlewycky at google.com
Tue Oct 22 21:16:21 PDT 2013


__sanitizer_report_error_summary is the replaceable interface for reporting
an error. This patch changes asan a tiny bit to always emit a summary
whenever it encounters an error. This is important, otherwise a library
user of asan will not be aware of errors that were merely printed.

Also, all these summaries are redundant with the non-summarized printouts.
Make the default weak implementation of report error summary not do
anything. This means we need to remove the check for SUMMARY lines from the
tests. This is suboptimal for testing, but printing out these redundant
lines is just bad UI.

Please review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131022/65ebf3b9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compiler-rt-summary-1.patch
Type: text/x-patch
Size: 7147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131022/65ebf3b9/attachment.bin>


More information about the cfe-commits mailing list