patch: sanitizer summaries are redundant, don't emit them

[Kostya Serebryany]

On Wed, Oct 23, 2013 at 8:16 AM, Nick Lewycky <nlewycky at google.com> wrote:

> __sanitizer_report_error_summary is the replaceable interface for
> reporting an error. This patch changes asan a tiny bit to always emit a
> summary whenever it encounters an error. This is important, otherwise a
> library user of asan will not be aware of errors that were merely printed.
>
> Also, all these summaries are redundant with the non-summarized printouts.
> Make the default weak implementation of report error summary not do
> anything. This means we need to remove the check for SUMMARY lines from the
> tests. This is suboptimal for testing, but printing out these redundant
> lines is just bad UI.
>

But I've added summaries for a reason: they help to cluster bug reports.
I'd really prefer to keep them by default.

--kcc



>
> Please review!
>
> Nick
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131023/cfbd32c3/attachment.html>