[PATCH] Use lowercase version of argv when determining driver mode
rnk at google.com
Tue Aug 20 14:48:36 PDT 2013
On Tue, Aug 20, 2013 at 2:44 PM, Hans Wennborg <hans at chromium.org> wrote:
> On Tue, Aug 20, 2013 at 2:26 PM, Reid Kleckner <rnk at google.com> wrote:
> >> std::string ProgName(llvm::sys::path::stem(ArgVector));
> >> + for (size_t i = 0, e = ProgName.length(); i != e; ++i)
> >> + ProgName[i] = toLowercase(ProgName[i]);
> > This is modern C++, we can't use for loops, what are we, farmers!?
> > std::transform(ProgName.begin(), ProgName.end(), ProgName.begin(),
> > ::toLowerCase);
> Sure, I've updated the patch.
> > Also, should we do this transform on non-Windows platforms?
> Yes, I think we should. Mostly because I don't see any reason not to,
> and the less platform-specific code, the better.
> New patch uploaded.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits