[PATCH] Use lowercase version of argv when determining driver mode
hans at chromium.org
Tue Aug 20 14:44:31 PDT 2013
On Tue, Aug 20, 2013 at 2:26 PM, Reid Kleckner <rnk at google.com> wrote:
>> std::string ProgName(llvm::sys::path::stem(ArgVector));
>> + for (size_t i = 0, e = ProgName.length(); i != e; ++i)
>> + ProgName[i] = toLowercase(ProgName[i]);
> This is modern C++, we can't use for loops, what are we, farmers!?
> std::transform(ProgName.begin(), ProgName.end(), ProgName.begin(),
Sure, I've updated the patch.
> Also, should we do this transform on non-Windows platforms?
Yes, I think we should. Mostly because I don't see any reason not to,
and the less platform-specific code, the better.
New patch uploaded.
More information about the cfe-commits