r188406 - Do no use -emit-llvm for -flto.

Shuxin Yang shuxin.llvm at gmail.com
Wed Aug 14 13:41:00 PDT 2013


My patch about "Driver::IsUsingLTO no longer return true when seeing 
-emit-llvm"
will change the behavior of "clang -emit-llvm a.c".  I think it is 
better to add testing
case after I commit that change.

I think it is better to complain for "clang -emit-llvm a.c" which is 
very confusing and have no practical uses.

On 8/14/13 1:08 PM, Eli Friedman wrote:
> If there's already coverage for the specific behavior this is testing, 
> that's fine... but that isn't equivalent to the existence of testcases 
> using -emit-llvm.
>
> -Eli
>
>
> On Wed, Aug 14, 2013 at 1:05 PM, Shuxin Yang <shuxin.llvm at gmail.com 
> <mailto:shuxin.llvm at gmail.com>> wrote:
>
>     I saw  lots of testing cases (under Driver/test) using -emit-llvm.
>     Is that sufficient?
>
>
>     On 8/14/13 1:01 PM, Eli Friedman wrote:
>>     On Wed, Aug 14, 2013 at 12:45 PM, Shuxin Yang
>>     <shuxin.llvm at gmail.com <mailto:shuxin.llvm at gmail.com>> wrote:
>>
>>         Author: shuxin_yang
>>         Date: Wed Aug 14 14:45:49 2013
>>         New Revision: 188406
>>
>>         URL: http://llvm.org/viewvc/llvm-project?rev=188406&view=rev
>>         Log:
>>         Do no use -emit-llvm for -flto.
>>
>>         Tested on multiple OSes.
>>
>>
>>     We still need tests for the behavior of -emit-llvm (although
>>     maybe they should be in a separate file).
>>
>>     -Eli
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130814/87143e2a/attachment.html>


More information about the cfe-commits mailing list