<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
My patch about "Driver::IsUsingLTO no longer return true when seeing
-emit-llvm" <br>
will change the behavior of "clang -emit-llvm a.c". I think it is
better to add testing <br>
case after I commit that change. <br>
<br>
I think it is better to complain for "clang -emit-llvm a.c" which is
very confusing and have no practical uses. <br>
<br>
<div class="moz-cite-prefix">On 8/14/13 1:08 PM, Eli Friedman wrote:<br>
</div>
<blockquote
cite="mid:CAJdarcE4XK=nkvE=jiQrndo=LUvB_vWaEbYo6CJbgxg6BMkJTw@mail.gmail.com"
type="cite">
<div dir="ltr">If there's already coverage for the specific
behavior this is testing, that's fine... but that isn't
equivalent to the existence of testcases using -emit-llvm.
<div><br>
</div>
<div>-Eli<br>
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Wed, Aug 14, 2013 at 1:05 PM,
Shuxin Yang <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:shuxin.llvm@gmail.com" target="_blank">shuxin.llvm@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I saw lots of
testing cases (under Driver/test) using -emit-llvm. Is
that sufficient?
<div>
<div class="h5"><br>
<br>
<div>On 8/14/13 1:01 PM, Eli Friedman wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">On Wed, Aug 14, 2013 at 12:45 PM,
Shuxin Yang <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:shuxin.llvm@gmail.com"
target="_blank">shuxin.llvm@gmail.com</a>></span>
wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">Author:
shuxin_yang<br>
Date: Wed Aug 14 14:45:49 2013<br>
New Revision: 188406<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=188406&view=rev"
target="_blank">http://llvm.org/viewvc/llvm-project?rev=188406&view=rev</a><br>
Log:<br>
Do no use -emit-llvm for -flto.<br>
<br>
Tested on multiple OSes.<br>
</blockquote>
<div><br>
</div>
<div>We still need tests for the behavior
of -emit-llvm (although maybe they
should be in a separate file).</div>
<div><br>
</div>
<div>-Eli</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>