r187174 - Fix GNU ObjC ABI for a message returning a struct.

John McCall rjmccall at apple.com
Fri Jul 26 13:58:13 PDT 2013

On Jul 25, 2013, at 5:53 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> Author: efriedma
> Date: Thu Jul 25 19:53:29 2013
> New Revision: 187174
> URL: http://llvm.org/viewvc/llvm-project?rev=187174&view=rev
> Log:
> Fix GNU ObjC ABI for a message returning a struct.
> This allows the ObjFW runtime to correctly implement message forwarding
> for messages which return a struct.
> Patch by Jonathan Schleifer.

Hey, Jonathan.

This isn’t really a language extension; it’s an ABI feature that fixes a language
feature.  I don’t think it rises to the level of being worth documenting in the
language-extensions section.

I’m also skeptical that this deserves to be exposed to the user with __has_feature.
Do you have a use case for that, or are you just doing it for generic reasons?

(I haven’t checked, so it’s possible you were asked to do both things by previous
code review, but I still disagree with those decisions.)

If it is important to expose this with __has_feature, you should really abstract this
into ObjCRuntime, like what we do with hasTerminate() (which I’ll note also does
not have a __has_feature check).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130726/096b4812/attachment.html>

More information about the cfe-commits mailing list