<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Jul 25, 2013, at 5:53 PM, Eli Friedman <<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>> wrote:<br><div><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: efriedma<br>Date: Thu Jul 25 19:53:29 2013<br>New Revision: 187174<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=187174&view=rev">http://llvm.org/viewvc/llvm-project?rev=187174&view=rev</a><br>Log:<br>Fix GNU ObjC ABI for a message returning a struct.<br><br>This allows the ObjFW runtime to correctly implement message forwarding<br>for messages which return a struct.<br><br>Patch by Jonathan Schleifer.<br></div></blockquote><div><br></div>Hey, Jonathan.</div><div><br></div><div>This isn’t really a language extension; it’s an ABI feature that fixes a language</div><div>feature. I don’t think it rises to the level of being worth documenting in the</div><div>language-extensions section.</div><div><br></div><div>I’m also skeptical that this deserves to be exposed to the user with __has_feature.</div><div>Do you have a use case for that, or are you just doing it for generic reasons?</div><div><br></div><div>(I haven’t checked, so it’s possible you were asked to do both things by previous</div><div>code review, but I still disagree with those decisions.)</div><div><br></div><div>If it is important to expose this with __has_feature, you should really abstract this</div><div>into ObjCRuntime, like what we do with hasTerminate() (which I’ll note also does</div><div>not have a __has_feature check).</div><div><br></div><div>John.</div></body></html>