[PATCH] Fix source location info for C++03 access declarations.

Eli Friedman eli.friedman at gmail.com
Fri Jul 12 11:53:09 PDT 2013


On Fri, Jul 12, 2013 at 7:22 AM, Enea Zaffanella <zaffanella at cs.unipr.it> wrote:
> Please find attached a patch (with testcases) that fixes the source location
> info for C++03 access declarations.
>
> While at it, some other improvements in code have been applied, such as:
>
> in a few helper methods of Sema.h:
>   * renamed isTypeName as HasTypenameKeyword;
>
> in UsingDecl (and UnresolvedUsingValueDecl, if appropriate):
>  * renamed is/setTypeName as has/setTypename
>  * renamed get/setUsingLocation to get/setUsingLoc
>  * added helper isAccessDeclaration()
>  * fixed getSourceRange
>  * fixed pretty printing
>
> in UnresolvedUsingTypenameDecl:
>  * set field UsingLocation in ctor, use it in getUsingLoc
>    and when (de-)serializing node.
>
> OK to commit?
>

Please split this patch.  It's practically unreadable as-is.

-Eli



More information about the cfe-commits mailing list