[PATCH] PR16344: Dereferencing null pointer cause SIGSEGV

[Richard Smith]

On Tue, Jun 25, 2013 at 7:31 AM, WenHan Gu (谷汶翰) <wenhan.gu at gmail.com> wrote:
> Thanks your review!
>
> Hi Richard, I guess lib/Sema is owned by you. Could you help commit if ok?
> Or who should I ask to help review and commit?

I ran the patch through clang-format (to fix an 80-column violation
and change a "* " to a " *") and committed in r184875.

You can ask anyone with Clang commit access to commit an approved
patch for you; it doesn't need to be the code owner.

> 2013/6/25 下午10:10 於 "Rafael Espíndola" <rafael.espindola at gmail.com> 寫道：
>
>> LGTM
>>
>> On 24 June 2013 21:35, WenHan Gu (谷汶翰) <wenhan.gu at gmail.com> wrote:
>> > Merge into existing testcase. Thanks!
>> >
>> > 2013/6/25 上午3:34 於 "Rafael Espíndola" <rafael.espindola at gmail.com> 寫道：
>> >
>> >> The test fails, since clang with -verify is looking for diagnostics to
>> >> match. You need to add expected-no-diagnostics to the test or if
>> >> possible merge the test with an existing file to reduce the number of
>> >> distinct tests that get run during a check-clang invocation.
>> >>
>> >> On 24 June 2013 14:34, WenHan Gu (谷汶翰) <wenhan.gu at gmail.com> wrote:
>> >> > Attached.
>> >> > Sorry for inconvenience.
>> >> >
>> >> > 2013/6/24 下午10:20 於 "Rafael Espíndola" <rafael.espindola at gmail.com>
>> >> > 寫道：
>> >> >
>> >> >> Your second patch is a link to google docs and it is failing to
>> >> >> download
>> >> >> for me. Would you mind just attaching the patch?
>> >> >>
>> >> >> Thanks,
>> >> >> Rafael
>> >> >>
>> >> >