[PATCH] PR16344: Dereferencing null pointer cause SIGSEGV

WenHan Gu (谷汶翰) wenhan.gu at gmail.com
Tue Jun 25 07:31:34 PDT 2013


Thanks your review!

Hi Richard, I guess lib/Sema is owned by you. Could you help commit if ok?
Or who should I ask to help review and commit?

Thanks!
2013/6/25 ÏÂÎç10:10 ì¶ "Rafael Esp¨ªndola" <rafael.espindola at gmail.com> Œ‘µÀ£º

> LGTM
>
> On 24 June 2013 21:35, WenHan Gu (¹Èã뺲) <wenhan.gu at gmail.com> wrote:
> > Merge into existing testcase. Thanks!
> >
> > 2013/6/25 ÉÏÎç3:34 ì¶ "Rafael Esp¨ªndola" <rafael.espindola at gmail.com> Œ‘µÀ£º
> >
> >> The test fails, since clang with -verify is looking for diagnostics to
> >> match. You need to add expected-no-diagnostics to the test or if
> >> possible merge the test with an existing file to reduce the number of
> >> distinct tests that get run during a check-clang invocation.
> >>
> >> On 24 June 2013 14:34, WenHan Gu (¹Èã뺲) <wenhan.gu at gmail.com> wrote:
> >> > Attached.
> >> > Sorry for inconvenience.
> >> >
> >> > 2013/6/24 ÏÂÎç10:20 ì¶ "Rafael Esp¨ªndola" <rafael.espindola at gmail.com>
> Œ‘µÀ£º
> >> >
> >> >> Your second patch is a link to google docs and it is failing to
> >> >> download
> >> >> for me. Would you mind just attaching the patch?
> >> >>
> >> >> Thanks,
> >> >> Rafael
> >> >>
> >> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130625/0a1b436e/attachment.html>


More information about the cfe-commits mailing list