[PATCH] [Sema] Re-land "Make FunctionType's TSI use unadjusted argument types"
eli.friedman at gmail.com
Tue Jun 11 12:16:58 PDT 2013
Err, wait, that's not right; I'm pretty sure you aren't changing the return
type of ParmVarDecl::getType() (correct me if I'm wrong). In that case,
you shouldn't be changing InitializedEntity::InitializeParameter, but
rather its caller.
On Tue, Jun 11, 2013 at 12:13 PM, Eli Friedman <eli.friedman at gmail.com>wrote:
> Sorry I didn't catch this the first time around, but why are you changing
> the return value of ParmVarDecl::getType()? ParmVarDecl::getOriginalType()
> already returns the type before adjustment.
> On Tue, Jun 11, 2013 at 12:02 PM, Reid Kleckner <rnk at google.com> wrote:
>> This was originaly r183614 which was reverted in r183616.
>> The fix here was to change InitializeParameter() to use
>> ASTContext::getSignatureParameterType() to avoid errors when trying to
>> initialize array parameters with normal pointers.
>> I had to change some objc tests which were getting extra qualifiers in
>> diagnostics, but they looked coincidental, not intentional.
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits