[PATCH] [Sema] Re-land "Make FunctionType's TSI use unadjusted argument types"

Eli Friedman eli.friedman at gmail.com
Tue Jun 11 12:13:24 PDT 2013


Sorry I didn't catch this the first time around, but why are you changing
the return value of ParmVarDecl::getType()?  ParmVarDecl::getOriginalType()
already returns the type before adjustment.

-Eli


On Tue, Jun 11, 2013 at 12:02 PM, Reid Kleckner <rnk at google.com> wrote:

> This was originaly r183614 which was reverted in r183616.
>
> The fix here was to change InitializeParameter() to use
> ASTContext::getSignatureParameterType() to avoid errors when trying to
> initialize array parameters with normal pointers.
>
> I had to change some objc tests which were getting extra qualifiers in
> diagnostics, but they looked coincidental, not intentional.
>
> http://llvm-reviews.chandlerc.com/D957
>
> Files:
>   include/clang/Sema/Initialization.h
>   lib/Sema/SemaDecl.cpp
>   lib/Sema/SemaType.cpp
>   test/Index/print-type.c
>   test/Index/print-type.cpp
>   test/Sema/function-redecl.c
>   test/Sema/function.c
>   test/SemaObjC/objc-literal-nsnumber.m
>   test/SemaObjCXX/arc-type-conversion.mm
>   test/SemaObjCXX/literals.mm
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130611/0dc087fe/attachment.html>


More information about the cfe-commits mailing list