[clang-tools-extra] r183417 - cpp11-migrate: Docs refresh

[Vane, Edwin]

> -----Original Message-----
> From: Sean Silva [mailto:silvas at purdue.edu]
> Sent: Thursday, June 06, 2013 12:46 PM
> To: Vane, Edwin
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [clang-tools-extra] r183417 - cpp11-migrate: Docs refresh
> 
> Sorry I didn't get to this while it was still in Phabricator. In the future, please split
> up logically separate changes into separate patches (this applies even for
> documentation).

What do you see as logically separate changes in this patch?
 
> +If you find a bug
> +
> +.. raw:: html
> +
> +  <input type="button" id="logbug" value="Log a Bug!" />  <script
> + type="text/javascript"
> + src="https://cpp11-migrate.atlassian.net/s/en_USpfg3b3-1988229788/6095
> + /34/1.4.0-m2/_/download/batch/com.atlassian.jira.collector.plugin.jira
> + -issue-collector-plugin:issuecollector/com.atlassian.jira.collector.pl
> + ugin.jira-issue-collector-plugin:issuecollector.js?collectorId=5081387
> + 4"></script>  <script type="text/javascript">window.ATL_JQ_PAGE_PROPS
> + =  {
> +    "triggerFunction": function(showCollectorDialog) {
> +      //Requries that jQuery is available!
> +      jQuery("#logbug").click(function(e) {
> +        e.preventDefault();
> +        showCollectorDialog();
> +      });
> +    }};
> +  </script>
> 
> 
> Could you just link to a "file a new bug" form instead of spewing this raw markup
> and modal dialog into the page?

I'm afraid that's how the issue collector works. There is no separate page for logging bugs anonymously. I can just disable anonymous bug loggings I just wanted to make it as easy as possible to log bugs.

> Just curious, but why do you guys have a separate bug tracker for cpp11-
> migrate?

Cpp11-migrate.atlassian.net is not just a bug tracker. It's our main way of doing project tracking. If people log bugs at llvm.org/bugs I just manually copy them into the project tracker anyway.

> 
> 
>  Transformations
> -===============
> +---------------
> 
> 
> Please stick to the standard adornments as laid out in
> llvm/docs/SphinxQuickstartTemplate.rst

I made this change because Sphinx was getting the section levels wrong. Sphinx has no absolute mapping between the section level and a markup so it tries to infer. I'll see if I can find another workaround.

> Tiny nit:
> 
> +In addition to the compiler arguments you usually build your code with,
> +you must provide the option for enabling C++11 features. For clang and
> +versions of gcc ≥ v4.8 this is ``-std=c++11``.

I take it Unicode is not allowed then? I wanted U+2265.

> 
> 
> 
> There seems to be some non-ASCII before "v4.8".
> 
> 
> -- Sean Silva