[PATCH] [ms-cxxabi] Fix the base/complete dtor logic.

Peter Collingbourne peter at pcc.me.uk
Sun May 19 15:26:19 PDT 2013


Hi timurrrr,

Previously it was thought that the Microsoft ABI used '?1' for
complete dtors.  In fact, '?1' is for base dtors, and '?_D' is for
complete dtors.  (Some confusion arose from documentation referring
to complete dtors as 'vbase dtors'.)  The dtor forms other than the
base dtor are emitted by a TU when required by that TU, even when
the body is not present.

Also, fix the implicit parameter belonging to deleting destructors.
That parameter is an integer, not a boolean.

http://llvm-reviews.chandlerc.com/D823

Files:
  include/clang/Basic/TargetCXXABI.h
  lib/AST/MicrosoftMangle.cpp
  lib/CodeGen/CGCXX.cpp
  lib/CodeGen/CGClass.cpp
  lib/CodeGen/CodeGenModule.cpp
  lib/CodeGen/MicrosoftCXXABI.cpp
  test/CodeGenCXX/microsoft-abi-static-initializers.cpp
  test/CodeGenCXX/microsoft-abi-structors.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D823.1.patch
Type: text/x-patch
Size: 17768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130519/8aea0db8/attachment.bin>


More information about the cfe-commits mailing list