[PATCH] [ms-cxxabi] Look up operator delete() at every virtual dtor declaration.

Richard Smith richard at metafoo.co.uk
Sun May 19 16:55:03 PDT 2013


  LGTM

  This approach is much closer to conforming than your summary implies: a virtual function is odr-used in every TU in which it is declared, so a virtual destructor must be defined in any program which declares it. Therefore we can reject a class definition if it declares a virtual destructor, and we know that the 'operator delete' lookup would fail. And (except in weird corner cases) that lookup will produce the same result in every TU where the class is complete.

http://llvm-reviews.chandlerc.com/D822

BRANCH
  dtors4

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list