PR15802 Windows paths with trailing backslashes

Nikola Smiljanic popizdeh at gmail.com
Mon Apr 22 19:58:28 PDT 2013


Here's a patch that tries to solve
http://llvm.org/bugs/show_bug.cgi?id=15802 The bug report contains a patch
that doesn't conform to coding standards and doesn't solve the general
issue. Basically backslashes must be escaped if they are followed by a
double quote, or in our case if they appear at the end of the argument
because clang puts quotes around every argument containing a backslash
which creates the backslashes followed by a double quote situation. The
solution is quadratic in nature but I don't think this makes a difference
as such input isn't something we should be seeing. I tried to solve this
with as little modifications to the existing code as possible.

More info on the crazy rules here
http://msdn.microsoft.com/en-us/library/bb776391%28v=vs.85%29.aspx
http://msdn.microsoft.com/en-us/library/17w5ykft%28v=vs.85%29.aspx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130423/66f72e80/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr15802
Type: application/octet-stream
Size: 1369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130423/66f72e80/attachment.obj>


More information about the cfe-commits mailing list