[patch] Make the ObjC attributes diagnostics a bit more informative

[jahanian]

On Apr 3, 2013, at 2:46 PM, Nico Weber <thakis at chromium.org> wrote:

> Hi,
> 
> the attached patch changes the attributes diag I added earlier today from
> 
>   test2.mm:3:12: error: postfix attributes are not allowed on Objective-C directives
> 
> to 
> 
>   test2.mm:3:12: error: postfix attributes are not allowed on Objective-C directives, place them in front of '@interface'
> 
> for @interface and @protocol (and keeps the diagnostic as is for @class and @implementation).

What is the rational for hint for @interface/@protocol and not others ?

- at implementation EXP I @end // expected-error {{postfix attributes are not allowed on Objective-C directives}}
+ at implementation EXP I @end // expected-error-re {{postfix attributes are not allowed on Objective-C directives$}}
                                                                              ????                                                                                        ??????

- at class EXP OC; // expected-error {{postfix attributes are not allowed on Objective-C directives}}
+ at class EXP OC; // expected-error-re {{postfix attributes are not allowed on Objective-C directives$}}

These don’t look right.

Also, why can’t you pass the token down instead of adding and using "enum ObjCAttrSkipHint”?

- Fariborz

> 
> Ok?
> 
> Nico
> <clang-objc-attrs-2.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130403/5961a29e/attachment.html>