<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 3, 2013, at 2:46 PM, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div dir="ltr">Hi,<div><br></div><div>the attached patch changes the attributes diag I added earlier today from</div><div><br></div><div><div> test2.mm:3:12: error: postfix attributes are not allowed on Objective-C directives</div><div><br></div><div>to </div><div><br></div><div><div> test2.mm:3:12: error: postfix attributes are not allowed on Objective-C directives, place them in front of '@interface'</div><div><br></div><div>for @interface and @protocol (and keeps the diagnostic as is for @class and @implementation).</div></div></div></div></div></blockquote><div><br></div>What is the rational for hint for @interface/@protocol and not others ?</div><div><br></div><div><div>-@implementation EXP I @end // expected-error {{postfix attributes are not allowed on Objective-C directives}}</div><div>+@implementation EXP I @end // expected-error-re {{postfix attributes are not allowed on Objective-C directives$}}</div><div> ???? ??????</div><div><br></div><div><div>-@class EXP OC; // expected-error {{postfix attributes are not allowed on Objective-C directives}}</div><div>+@class EXP OC; // expected-error-re {{postfix attributes are not allowed on Objective-C directives$}}</div><div><br></div><div>These don’t look right.</div><div><br></div><div>Also, why can’t you pass the token down instead of adding and using "enum ObjCAttrSkipHint”?</div><div><br></div><div>- Fariborz</div><div><br></div></div><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div><div><div><br></div><div>Ok?</div><div><br></div><div>Nico</div></div></div></div><span><clang-objc-attrs-2.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></body></html>