About commit TILE-Gx backend to community repository and default disabled
jiwang at tilera.com
Fri Mar 15 01:54:37 PDT 2013
on 2013/3/15 16:28, Chandler Carruth wrote:
thanks for feedback.
> I've not looked in detail at any of the patches, or any of the review
> threads, but unless you receive a very explicit LGTM from one of the
> committers to a particular area, I think you should hold off submitting.
sure, I am keep this in mind and will follow it.
> For a really large new body of code like this, I think having at least
> some pre-commit review is important. I think it is especially
> important for new contributors to the project to help bring them up to
> speed. Unfortunately, this is a *huge* amount of code, and so it is
> likely to take quite some time to really get reviews on all of it.
> Please be patient in that regard.
> The best thing you can do to help accelerate the process is to dive in
> and contribute to the shared parts of the open source project to help
> the current maintainers, and maybe even free up some of their time to
> review your patches. Because LLVM is open source, it is really
> important to the project for folks working on a specific target,
> backend, or application to also help share the ongoing maintenance and
> improvement costs of the core shared infrastructure in the compiler.
yes, some of these points are also my thoughts. but it will be hard
to follow before tilegx merged to llvm community, because it will take
much time to keep pace, and I need re-test, re-patch etc.
I agree that everyone should contribute to keep the community active
and vigorious. But I think there are difference between contributors.
some are focused and with expertise on middle end, while others may
on front or back end. so the normal way for a new contributor is, find a
familiar point to start, then go deeper and wider and expand one's
contribution during this process.
For Tilera corporation and me, we would like the keep tilegx backend
actively maintained and improved, and wish it could be a good target to
improve and test VLIW, many core features etc.
> On Fri, Mar 15, 2013 at 12:15 AM, Jiong Wang <jiwang at tilera.com
> <mailto:jiwang at tilera.com>> wrote:
> Hi All,
> As you have seen, I had sent all tilegx patches to get code
> review, and
> thanks for all the feedbacks on coding style and simplifing the code.
> So, is it OK to commit TILE-Gx backend to community master and let it
> default disabled?
> Tilera's recent plan about TILE-Gx backend is:
> 1. merge the current tilegx support to community master, so that we
> could go on the next stage development with more community
> including AsmParser for VLIW bundle, hardware float optimization, SIMD
> support etc.
> 2. we will contribute a tilegx buildbot once the code merged, so that
> it's good for both the community and company to monitor tilegx status.
> Actually, I have verified the buildbot environment on tilegx
> server, all
> OK, just wait for the merge, then it could svn co code from community
> and build :)
> if there is any important step I have missed or am wrong that block
> tilegx backend committed, please feel free to point out so that I
> correct it.
> thank you, looking forward to your reply.
> Tilera Corporation.
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits