About commit TILE-Gx backend to community repository and default disabled

Chandler Carruth chandlerc at google.com
Fri Mar 15 01:28:37 PDT 2013

I've not looked in detail at any of the patches, or any of the review
threads, but unless you receive a very explicit LGTM from one of the
committers to a particular area, I think you should hold off submitting.

For a really large new body of code like this, I think having at least some
pre-commit review is important. I think it is especially important for new
contributors to the project to help bring them up to speed. Unfortunately,
this is a *huge* amount of code, and so it is likely to take quite some
time to really get reviews on all of it. Please be patient in that regard.

The best thing you can do to help accelerate the process is to dive in and
contribute to the shared parts of the open source project to help the
current maintainers, and maybe even free up some of their time to review
your patches. Because LLVM is open source, it is really important to the
project for folks working on a specific target, backend, or application to
also help share the ongoing maintenance and improvement costs of the core
shared infrastructure in the compiler.


On Fri, Mar 15, 2013 at 12:15 AM, Jiong Wang <jiwang at tilera.com> wrote:

> Hi All,
> As you have seen, I had sent all tilegx patches to get code review, and
> thanks for all the feedbacks on coding style and simplifing the code.
> So, is it OK to commit TILE-Gx backend to community master and let it
> default disabled?
> Tilera's recent plan about TILE-Gx backend is:
> 1. merge the current tilegx support to community master, so that we
> could go on the next stage development with more community interaction,
> including AsmParser for VLIW bundle, hardware float optimization, SIMD
> support etc.
> 2. we will contribute a tilegx buildbot once the code merged, so that
> it's good for both the community and company to monitor tilegx status.
> Actually, I have verified the buildbot environment on tilegx server, all
> OK, just wait for the merge, then it could svn co code from community
> and build :)
> if there is any important step I have missed or am wrong that block
> tilegx backend committed, please feel free to point out so that I could
> correct it.
> thank you, looking forward to your reply.
> ---
> Regards,
> Jiong
> Tilera Corporation.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130315/6c48b49a/attachment.html>

More information about the cfe-commits mailing list