[OpenCL patch] vec_type_hint

Tanya Lattner lattner at apple.com
Thu Mar 7 15:17:15 PST 2013


Seems fine.

-Tanya

On Mar 7, 2013, at 5:47 AM, Murat Bolat <murat.bolat at arm.com> wrote:

> Hi,
>  
> I incorporated the Guy Benyei’s patch  and modified the patch based on Joey Gouly’s suggestion.
> I attached the patch for the vec_type_hint attribute.
>  
> Thanks a lot!
> Murat Bolat
>  
> From: Benyei, Guy [mailto:guy.benyei at intel.com] 
> Sent: 07 March 2013 11:28
> To: Murat Bolat; cfe-commits at cs.uiuc.edu
> Subject: RE: [OpenCL patch] vec_type_hint
>  
> Hi,
> I think you should use a pattern similar to the ones used in other attributes, instead of adding a qualtype field to AttributeList that’s not in use most of the time. Attached my implementation for this part of the patch, please take a look at it.
>  
> Thanks
> <image001.png>
>  
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Murat Bolat
> Sent: Wednesday, March 06, 2013 20:04
> To: cfe-commits at cs.uiuc.edu
> Subject: [OpenCL patch] vec_type_hint
>  
> Hi all,
>  
> Here is the updated patch for vec_type_hint attribute in OpenCL.
> The previous discussion about it:
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120813/062502.html
>  
> Thanks a lot!
> Murat Bolat
>  
> <VecTypeHint.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/5b5cb489/attachment.html>


More information about the cfe-commits mailing list