[OpenCL patch] vec_type_hint

Joey Gouly Joey.Gouly at arm.com
Thu Mar 7 05:52:29 PST 2013


LGTM.

From: Murat Bolat
Sent: 07 March 2013 13:48
To: cfe-commits at cs.uiuc.edu
Cc: 'Benyei, Guy'; Joey Gouly
Subject: RE: [OpenCL patch] vec_type_hint

Hi,

I incorporated the Guy Benyei's patch  and modified the patch based on Joey Gouly's suggestion.
I attached the patch for the vec_type_hint attribute.

Thanks a lot!
Murat Bolat

From: Benyei, Guy [mailto:guy.benyei at intel.com]
Sent: 07 March 2013 11:28
To: Murat Bolat; cfe-commits at cs.uiuc.edu
Subject: RE: [OpenCL patch] vec_type_hint

Hi,
I think you should use a pattern similar to the ones used in other attributes, instead of adding a qualtype field to AttributeList that's not in use most of the time. Attached my implementation for this part of the patch, please take a look at it.

Thanks


From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Murat Bolat
Sent: Wednesday, March 06, 2013 20:04
To: cfe-commits at cs.uiuc.edu
Subject: [OpenCL patch] vec_type_hint

Hi all,

Here is the updated patch for vec_type_hint attribute in OpenCL.
The previous discussion about it:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120813/062502.html

Thanks a lot!
Murat Bolat


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.





More information about the cfe-commits mailing list